fix : 컨트롤러 검증 → FormRequest 분리
This commit is contained in:
@@ -5,7 +5,9 @@
|
||||
use App\Helpers\ApiResponse;
|
||||
use App\Http\Controllers\Controller;
|
||||
use App\Services\Design\ModelService;
|
||||
use Illuminate\Http\Request;
|
||||
use App\Http\Requests\Common\PaginateRequest;
|
||||
use App\Http\Requests\Design\Model\StoreRequest;
|
||||
use App\Http\Requests\Design\Model\UpdateRequest;
|
||||
|
||||
class DesignModelController extends Controller
|
||||
{
|
||||
@@ -13,48 +15,35 @@ public function __construct(
|
||||
protected ModelService $service
|
||||
) {}
|
||||
|
||||
public function index(Request $request)
|
||||
public function index(PaginateRequest $request)
|
||||
{
|
||||
return ApiResponse::handle(function () use ($request) {
|
||||
$q = $request->query('q', '');
|
||||
$page = (int) $request->query('page', 1);
|
||||
$size = (int) $request->query('size', 20);
|
||||
$p = $request->validatedOrDefaults();
|
||||
$q = $p['q'] ?? '';
|
||||
$page = (int) $p['page'];
|
||||
$size = (int) $p['size'];
|
||||
|
||||
// 현재 서비스 시그니처가 list($q, $page, $size)이므로 정합 유지
|
||||
return $this->service->list($q, $page, $size);
|
||||
}, __('message.fetched'));
|
||||
}
|
||||
|
||||
public function store(Request $request)
|
||||
public function store(StoreRequest $request)
|
||||
{
|
||||
return ApiResponse::handle(function () use ($request) {
|
||||
$payload = $request->validate([
|
||||
'code' => 'required|string|max:100',
|
||||
'name' => 'required|string|max:200',
|
||||
'category_id' => 'nullable|integer',
|
||||
'lifecycle' => 'nullable|string|max:30',
|
||||
'description' => 'nullable|string',
|
||||
'is_active' => 'boolean',
|
||||
]);
|
||||
return $this->service->create($payload);
|
||||
return $this->service->create($request->validated());
|
||||
}, __('message.created'));
|
||||
}
|
||||
|
||||
public function show(int $id)
|
||||
{
|
||||
return ApiResponse::handle(fn() => $this->service->find($id), __('message.fetched'));
|
||||
return ApiResponse::handle(fn () => $this->service->find($id), __('message.fetched'));
|
||||
}
|
||||
|
||||
public function update(Request $request, int $id)
|
||||
public function update(UpdateRequest $request, int $id)
|
||||
{
|
||||
return ApiResponse::handle(function () use ($request, $id) {
|
||||
$payload = $request->validate([
|
||||
'code' => 'sometimes|string|max:100',
|
||||
'name' => 'sometimes|string|max:200',
|
||||
'category_id' => 'nullable|integer',
|
||||
'lifecycle' => 'nullable|string|max:30',
|
||||
'description' => 'nullable|string',
|
||||
'is_active' => 'boolean',
|
||||
]);
|
||||
return $this->service->update($id, $payload);
|
||||
return $this->service->update($id, $request->validated());
|
||||
}, __('message.updated'));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user