SamProject/sam-api
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: ApiResponse 4xx 에러에서 스택 트레이스 제외 및 Controller 메서드 수정

Browse Source 
- 4xx 클라이언트 에러에는 스택 트레이스 제외
- 5xx 서버 에러에만 debug 모드에서 스택 트레이스 포함
- 10개 Controller의 ApiResponse::handle() → success() 수정
  - BankAccountController, SiteController, CardController
  - DepositController, WithdrawalController, SaleController
  - PurchaseController, PayrollController, ReportController
  - WorkSettingController
- import 경로 수정 (App\Http\Responses → App\Helpers)
This commit is contained in:
권혁성
2025-12-18 15:42:46 +09:00
parent 8ad4d7c0ce
commit 7278c4742f
12 changed files with 104 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/Http/Controllers/Api/V1/BankAccountController.php
View File

@@ -5,7 +5,7 @@
use App\Http\Controllers\Controller;
use App\Http\Requests\V1\BankAccount\StoreBankAccountRequest;
use App\Http\Requests\V1\BankAccount\UpdateBankAccountRequest;
use App\Http\Responses\ApiResponse;
use App\Helpers\ApiResponse;
use App\Services\BankAccountService;
use Illuminate\Http\Request;
@@ -33,7 +33,7 @@ public function index(Request $request)
$accounts = $this->service->index($params);
return ApiResponse::handle(__('message.fetched'), $accounts);
return ApiResponse::success($accounts, __('message.fetched'));
}
/**
@@ -43,7 +43,7 @@ public function store(StoreBankAccountRequest $request)
{
$account = $this->service->store($request->validated());
return ApiResponse::handle(__('message.created'), $account, 201);
return ApiResponse::success($account, __('message.created'), [], 201);
}
/**
@@ -53,7 +53,7 @@ public function show(int $id)
{
$account = $this->service->show($id);
return ApiResponse::handle(__('message.fetched'), $account);
return ApiResponse::success($account, __('message.fetched'));
}
/**
@@ -63,7 +63,7 @@ public function update(int $id, UpdateBankAccountRequest $request)
{
$account = $this->service->update($id, $request->validated());
return ApiResponse::handle(__('message.updated'), $account);
return ApiResponse::success($account, __('message.updated'));
}
/**
@@ -73,7 +73,7 @@ public function destroy(int $id)
{
$this->service->destroy($id);
return ApiResponse::handle(__('message.deleted'));
return ApiResponse::success(null, __('message.deleted'));
}
/**
@@ -83,7 +83,7 @@ public function toggle(int $id)
{
$account = $this->service->toggleStatus($id);
return ApiResponse::handle(__('message.updated'), $account);
return ApiResponse::success($account, __('message.updated'));
}
/**
@@ -93,7 +93,7 @@ public function setPrimary(int $id)
{
$account = $this->service->setPrimary($id);
return ApiResponse::handle(__('message.updated'), $account);
return ApiResponse::success($account, __('message.updated'));
}
/**
@@ -103,6 +103,6 @@ public function active()
{
$accounts = $this->service->getActiveAccounts();
return ApiResponse::handle(__('message.fetched'), $accounts);
return ApiResponse::success($accounts, __('message.fetched'));
}
}