fix: ApiResponse 4xx 에러에서 스택 트레이스 제외 및 Controller 메서드 수정
- 4xx 클라이언트 에러에는 스택 트레이스 제외 - 5xx 서버 에러에만 debug 모드에서 스택 트레이스 포함 - 10개 Controller의 ApiResponse::handle() → success() 수정 - BankAccountController, SiteController, CardController - DepositController, WithdrawalController, SaleController - PurchaseController, PayrollController, ReportController - WorkSettingController - import 경로 수정 (App\Http\Responses → App\Helpers)
This commit is contained in:
@@ -8,7 +8,7 @@
|
||||
use App\Http\Requests\V1\Payroll\StorePayrollRequest;
|
||||
use App\Http\Requests\V1\Payroll\UpdatePayrollRequest;
|
||||
use App\Http\Requests\V1\Payroll\UpdatePayrollSettingRequest;
|
||||
use App\Http\Responses\ApiResponse;
|
||||
use App\Helpers\ApiResponse;
|
||||
use App\Services\PayrollService;
|
||||
use Illuminate\Http\Request;
|
||||
|
||||
@@ -37,7 +37,7 @@ public function index(Request $request)
|
||||
|
||||
$payrolls = $this->service->index($params);
|
||||
|
||||
return ApiResponse::handle(__('message.fetched'), $payrolls);
|
||||
return ApiResponse::success($payrolls, __('message.fetched'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -50,7 +50,7 @@ public function summary(Request $request)
|
||||
|
||||
$summary = $this->service->summary($year, $month);
|
||||
|
||||
return ApiResponse::handle(__('message.fetched'), $summary);
|
||||
return ApiResponse::success($summary, __('message.fetched'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -60,7 +60,7 @@ public function store(StorePayrollRequest $request)
|
||||
{
|
||||
$payroll = $this->service->store($request->validated());
|
||||
|
||||
return ApiResponse::handle(__('message.created'), $payroll, 201);
|
||||
return ApiResponse::success($payroll, __('message.created'), [], 201);
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -70,7 +70,7 @@ public function show(int $id)
|
||||
{
|
||||
$payroll = $this->service->show($id);
|
||||
|
||||
return ApiResponse::handle(__('message.fetched'), $payroll);
|
||||
return ApiResponse::success($payroll, __('message.fetched'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -80,7 +80,7 @@ public function update(int $id, UpdatePayrollRequest $request)
|
||||
{
|
||||
$payroll = $this->service->update($id, $request->validated());
|
||||
|
||||
return ApiResponse::handle(__('message.updated'), $payroll);
|
||||
return ApiResponse::success($payroll, __('message.updated'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -90,7 +90,7 @@ public function destroy(int $id)
|
||||
{
|
||||
$this->service->destroy($id);
|
||||
|
||||
return ApiResponse::handle(__('message.deleted'));
|
||||
return ApiResponse::success(null, __('message.deleted'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -100,7 +100,7 @@ public function confirm(int $id)
|
||||
{
|
||||
$payroll = $this->service->confirm($id);
|
||||
|
||||
return ApiResponse::handle(__('message.payroll.confirmed'), $payroll);
|
||||
return ApiResponse::success($payroll, __('message.payroll.confirmed'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -110,7 +110,7 @@ public function pay(int $id, PayPayrollRequest $request)
|
||||
{
|
||||
$payroll = $this->service->pay($id, $request->input('withdrawal_id'));
|
||||
|
||||
return ApiResponse::handle(__('message.payroll.paid'), $payroll);
|
||||
return ApiResponse::success($payroll, __('message.payroll.paid'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -123,7 +123,7 @@ public function bulkConfirm(Request $request)
|
||||
|
||||
$count = $this->service->bulkConfirm($year, $month);
|
||||
|
||||
return ApiResponse::handle(__('message.payroll.bulk_confirmed'), ['count' => $count]);
|
||||
return ApiResponse::success(['count' => $count], __('message.payroll.bulk_confirmed'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -133,7 +133,7 @@ public function payslip(int $id)
|
||||
{
|
||||
$payslip = $this->service->payslip($id);
|
||||
|
||||
return ApiResponse::handle(__('message.fetched'), $payslip);
|
||||
return ApiResponse::success($payslip, __('message.fetched'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -147,7 +147,7 @@ public function calculate(CalculatePayrollRequest $request)
|
||||
|
||||
$payrolls = $this->service->calculate($year, $month, $userIds);
|
||||
|
||||
return ApiResponse::handle(__('message.payroll.calculated'), $payrolls);
|
||||
return ApiResponse::success($payrolls, __('message.payroll.calculated'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -157,7 +157,7 @@ public function getSettings()
|
||||
{
|
||||
$settings = $this->service->getSettings();
|
||||
|
||||
return ApiResponse::handle(__('message.fetched'), $settings);
|
||||
return ApiResponse::success($settings, __('message.fetched'));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -167,6 +167,6 @@ public function updateSettings(UpdatePayrollSettingRequest $request)
|
||||
{
|
||||
$settings = $this->service->updateSettings($request->validated());
|
||||
|
||||
return ApiResponse::handle(__('message.updated'), $settings);
|
||||
return ApiResponse::success($settings, __('message.updated'));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user