SamProject/sam-api
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: ClientApi.php Swagger 점검 및 개선 (Phase 3-3)

Browse Source 
- ClientStoreRequest.php 생성 (검증 로직 분리)
- ClientUpdateRequest.php 생성 (검증 로직 분리)
- ClientController.php FormRequest 적용 및 패턴 통일
- lang/ko/message.php client 메시지 키 추가
- ApiResponse::handle 패턴 통일 (메시지 두 번째 인자)
- SAM API Development Rules 준수 완료
This commit is contained in:
권혁성
2025-11-07 02:40:18 +09:00
parent f4d663ac4e
commit c87aadc357
5 changed files with 416 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
app/Http/Controllers/Api/V1/ClientController.php
View File

@@ -4,69 +4,55 @@
use App\Helpers\ApiResponse;
use App\Http\Controllers\Controller;
use App\Http\Requests\Client\ClientStoreRequest;
use App\Http\Requests\Client\ClientUpdateRequest;
use App\Services\ClientService;
use Illuminate\Http\Request;
class ClientController extends Controller
{
protected ClientService $service;
public function __construct(ClientService $service)
{
$this->service = $service;
}
public function __construct(private ClientService $service) {}
public function index(Request $request)
{
return ApiResponse::handle(function () use ($request) {
$data = $this->service->index($request->all());
return ['data' => $data, 'message' => __('message.fetched')];
});
return $this->service->index($request->all());
}, __('message.client.fetched'));
}
public function show(int $id)
{
return ApiResponse::handle(function () use ($id) {
$data = $this->service->show($id);
return ['data' => $data, 'message' => __('message.fetched')];
});
return $this->service->show($id);
}, __('message.client.fetched'));
}
public function store(Request $request)
public function store(ClientStoreRequest $request)
{
return ApiResponse::handle(function () use ($request) {
$data = $this->service->store($request->all());
return ['data' => $data, 'message' => __('message.created')];
});
return $this->service->store($request->validated());
}, __('message.client.created'));
}
public function update(Request $request, int $id)
public function update(ClientUpdateRequest $request, int $id)
{
return ApiResponse::handle(function () use ($request, $id) {
$data = $this->service->update($id, $request->all());
return ['data' => $data, 'message' => __('message.updated')];
});
return $this->service->update($id, $request->validated());
}, __('message.client.updated'));
}
public function destroy(int $id)
{
return ApiResponse::handle(function () use ($id) {
$this->service->destroy($id);
return ['data' => null, 'message' => __('message.deleted')];
});
return 'success';
}, __('message.client.deleted'));
}
public function toggle(int $id)
{
return ApiResponse::handle(function () use ($id) {
$data = $this->service->toggle($id);
return ['data' => $data, 'message' => __('message.updated')];
});
return $this->service->toggle($id);
}, __('message.client.toggled'));
}
}
}

27
app/Http/Requests/Client/ClientStoreRequest.php Normal file
View File

@@ -0,0 +1,27 @@
<?php
namespace App\Http\Requests\Client;
use Illuminate\Foundation\Http\FormRequest;
class ClientStoreRequest extends FormRequest
{
public function authorize(): bool
{
return true;
}
public function rules(): array
{
return [
'client_group_id' => 'nullable|integer',
'client_code' => 'required|string|max:50',
'name' => 'required|string|max:100',
'contact_person' => 'nullable|string|max:100',
'phone' => 'nullable|string|max:20',
'email' => 'nullable|email|max:100',
'address' => 'nullable|string|max:255',
'is_active' => 'nullable|in:Y,N',
];
}
}

27
app/Http/Requests/Client/ClientUpdateRequest.php Normal file
View File

@@ -0,0 +1,27 @@
<?php
namespace App\Http\Requests\Client;
use Illuminate\Foundation\Http\FormRequest;
class ClientUpdateRequest extends FormRequest
{
public function authorize(): bool
{
return true;
}
public function rules(): array
{
return [
'client_group_id' => 'nullable|integer',
'client_code' => 'sometimes|string|max:50',
'name' => 'sometimes|string|max:100',
'contact_person' => 'nullable|string|max:100',
'phone' => 'nullable|string|max:20',
'email' => 'nullable|email|max:100',
'address' => 'nullable|string|max:255',
'is_active' => 'nullable|in:Y,N',
];
}
}