From e6f13e387068ed67e3c7b9a5c04a15724ec7c83e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=9C=A0=EB=B3=91=EC=B2=A0?= Date: Mon, 9 Mar 2026 11:21:20 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20[=EC=84=B8=EA=B8=88=EA=B3=84?= =?UTF-8?q?=EC=82=B0=EC=84=9C/=EB=B0=94=EB=A1=9C=EB=B9=8C]=20ApiResponse::?= =?UTF-8?q?handle()=20=ED=81=B4=EB=A1=9C=EC=A0=80=20=ED=8C=A8=ED=84=B4?= =?UTF-8?q?=EC=9C=BC=EB=A1=9C=20=ED=86=B5=EC=9D=BC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - BarobillSettingController: show/save/testConnection 클로저 방식 전환 - TaxInvoiceController: 전체 액션(index/show/store/update/destroy/issue/bulkIssue/cancel/checkStatus/summary) 클로저 방식 전환 - 중간 변수 할당 제거, 일관된 응답 패턴 적용 Co-Authored-By: Claude Opus 4.6 --- .../Api/V1/BarobillSettingController.php | 27 ++---- .../Api/V1/TaxInvoiceController.php | 91 +++++++------------ 2 files changed, 40 insertions(+), 78 deletions(-) diff --git a/app/Http/Controllers/Api/V1/BarobillSettingController.php b/app/Http/Controllers/Api/V1/BarobillSettingController.php index 9980397..ba16b88 100644 --- a/app/Http/Controllers/Api/V1/BarobillSettingController.php +++ b/app/Http/Controllers/Api/V1/BarobillSettingController.php @@ -18,12 +18,9 @@ public function __construct( */ public function show() { - $setting = $this->barobillService->getSetting(); - - return ApiResponse::handle( - data: $setting, - message: __('message.fetched') - ); + return ApiResponse::handle(function () { + return $this->barobillService->getSetting(); + }, __('message.fetched')); } /** @@ -31,12 +28,9 @@ public function show() */ public function save(SaveBarobillSettingRequest $request) { - $setting = $this->barobillService->saveSetting($request->validated()); - - return ApiResponse::handle( - data: $setting, - message: __('message.saved') - ); + return ApiResponse::handle(function () use ($request) { + return $this->barobillService->saveSetting($request->validated()); + }, __('message.saved')); } /** @@ -44,11 +38,8 @@ public function save(SaveBarobillSettingRequest $request) */ public function testConnection() { - $result = $this->barobillService->testConnection(); - - return ApiResponse::handle( - data: $result, - message: __('message.barobill.connection_success') - ); + return ApiResponse::handle(function () { + return $this->barobillService->testConnection(); + }, __('message.barobill.connection_success')); } } diff --git a/app/Http/Controllers/Api/V1/TaxInvoiceController.php b/app/Http/Controllers/Api/V1/TaxInvoiceController.php index 08dcdb2..1d65ada 100644 --- a/app/Http/Controllers/Api/V1/TaxInvoiceController.php +++ b/app/Http/Controllers/Api/V1/TaxInvoiceController.php @@ -28,12 +28,9 @@ public function __construct( */ public function index(TaxInvoiceListRequest $request) { - $taxInvoices = $this->taxInvoiceService->list($request->validated()); - - return ApiResponse::handle( - data: $taxInvoices, - message: __('message.fetched') - ); + return ApiResponse::handle(function () use ($request) { + return $this->taxInvoiceService->list($request->validated()); + }, __('message.fetched')); } /** @@ -41,12 +38,9 @@ public function index(TaxInvoiceListRequest $request) */ public function show(int $id) { - $taxInvoice = $this->taxInvoiceService->show($id); - - return ApiResponse::handle( - data: $taxInvoice, - message: __('message.fetched') - ); + return ApiResponse::handle(function () use ($id) { + return $this->taxInvoiceService->show($id); + }, __('message.fetched')); } /** @@ -54,13 +48,9 @@ public function show(int $id) */ public function store(CreateTaxInvoiceRequest $request) { - $taxInvoice = $this->taxInvoiceService->create($request->validated()); - - return ApiResponse::handle( - data: $taxInvoice, - message: __('message.created'), - status: 201 - ); + return ApiResponse::handle(function () use ($request) { + return $this->taxInvoiceService->create($request->validated()); + }, __('message.created')); } /** @@ -68,12 +58,9 @@ public function store(CreateTaxInvoiceRequest $request) */ public function update(UpdateTaxInvoiceRequest $request, int $id) { - $taxInvoice = $this->taxInvoiceService->update($id, $request->validated()); - - return ApiResponse::handle( - data: $taxInvoice, - message: __('message.updated') - ); + return ApiResponse::handle(function () use ($request, $id) { + return $this->taxInvoiceService->update($id, $request->validated()); + }, __('message.updated')); } /** @@ -81,12 +68,11 @@ public function update(UpdateTaxInvoiceRequest $request, int $id) */ public function destroy(int $id) { - $this->taxInvoiceService->delete($id); + return ApiResponse::handle(function () use ($id) { + $this->taxInvoiceService->delete($id); - return ApiResponse::handle( - data: null, - message: __('message.deleted') - ); + return null; + }, __('message.deleted')); } /** @@ -94,12 +80,9 @@ public function destroy(int $id) */ public function issue(int $id) { - $taxInvoice = $this->taxInvoiceService->issue($id); - - return ApiResponse::handle( - data: $taxInvoice, - message: __('message.tax_invoice.issued') - ); + return ApiResponse::handle(function () use ($id) { + return $this->taxInvoiceService->issue($id); + }, __('message.tax_invoice.issued')); } /** @@ -107,12 +90,9 @@ public function issue(int $id) */ public function bulkIssue(BulkIssueRequest $request) { - $result = $this->taxInvoiceService->bulkIssue($request->getIds()); - - return ApiResponse::handle( - data: $result, - message: __('message.tax_invoice.bulk_issued') - ); + return ApiResponse::handle(function () use ($request) { + return $this->taxInvoiceService->bulkIssue($request->getIds()); + }, __('message.tax_invoice.bulk_issued')); } /** @@ -120,12 +100,9 @@ public function bulkIssue(BulkIssueRequest $request) */ public function cancel(CancelTaxInvoiceRequest $request, int $id) { - $taxInvoice = $this->taxInvoiceService->cancel($id, $request->validated()['reason']); - - return ApiResponse::handle( - data: $taxInvoice, - message: __('message.tax_invoice.cancelled') - ); + return ApiResponse::handle(function () use ($request, $id) { + return $this->taxInvoiceService->cancel($id, $request->validated()['reason']); + }, __('message.tax_invoice.cancelled')); } /** @@ -133,12 +110,9 @@ public function cancel(CancelTaxInvoiceRequest $request, int $id) */ public function checkStatus(int $id) { - $taxInvoice = $this->taxInvoiceService->checkStatus($id); - - return ApiResponse::handle( - data: $taxInvoice, - message: __('message.fetched') - ); + return ApiResponse::handle(function () use ($id) { + return $this->taxInvoiceService->checkStatus($id); + }, __('message.fetched')); } /** @@ -146,12 +120,9 @@ public function checkStatus(int $id) */ public function summary(TaxInvoiceSummaryRequest $request) { - $summary = $this->taxInvoiceService->summary($request->validated()); - - return ApiResponse::handle( - data: $summary, - message: __('message.fetched') - ); + return ApiResponse::handle(function () use ($request) { + return $this->taxInvoiceService->summary($request->validated()); + }, __('message.fetched')); } // =========================================================================