From ef33540940b46c6a8159aa4bd72f821fc20071ab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=EA=B9=80=EB=B3=B4=EA=B3=A4?=
 <lightone2017@codebridge-x.com>
Date: Sat, 21 Feb 2026 08:35:00 +0900
Subject: [PATCH] =?UTF-8?q?fix:=20[tax-invoice]=20ApiResponse::handle()=20?=
 =?UTF-8?q?=ED=98=B8=EC=B6=9C=20=EB=B0=A9=EC=8B=9D=20=EC=88=98=EC=A0=95?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- named parameter(data:, message:) → callable 콜백 패턴으로 전환
- ApiResponse::handle(fn () => ..., '제목') 형식 적용
- 기존 scaffold 코드의 잘못된 호출 방식 전체 수정
---
 .../Api/V1/TaxInvoiceController.php           | 80 ++++++-------------
 1 file changed, 26 insertions(+), 54 deletions(-)

diff --git a/app/Http/Controllers/Api/V1/TaxInvoiceController.php b/app/Http/Controllers/Api/V1/TaxInvoiceController.php
index fabda45..e0f9dc0 100644
--- a/app/Http/Controllers/Api/V1/TaxInvoiceController.php
+++ b/app/Http/Controllers/Api/V1/TaxInvoiceController.php
@@ -24,11 +24,9 @@ public function __construct(
      */
     public function index(TaxInvoiceListRequest $request)
     {
-        $taxInvoices = $this->taxInvoiceService->list($request->validated());
-
         return ApiResponse::handle(
-            data: $taxInvoices,
-            message: __('message.fetched')
+            fn () => $this->taxInvoiceService->list($request->validated()),
+            __('message.fetched')
         );
     }
 
@@ -37,11 +35,9 @@ public function index(TaxInvoiceListRequest $request)
      */
     public function show(int $id)
     {
-        $taxInvoice = $this->taxInvoiceService->show($id);
-
         return ApiResponse::handle(
-            data: $taxInvoice,
-            message: __('message.fetched')
+            fn () => $this->taxInvoiceService->show($id),
+            __('message.fetched')
         );
     }
 
@@ -50,12 +46,9 @@ public function show(int $id)
      */
     public function store(CreateTaxInvoiceRequest $request)
     {
-        $taxInvoice = $this->taxInvoiceService->create($request->validated());
-
         return ApiResponse::handle(
-            data: $taxInvoice,
-            message: __('message.created'),
-            status: 201
+            fn () => $this->taxInvoiceService->create($request->validated()),
+            __('message.created')
         );
     }
 
@@ -64,11 +57,9 @@ public function store(CreateTaxInvoiceRequest $request)
      */
     public function update(UpdateTaxInvoiceRequest $request, int $id)
     {
-        $taxInvoice = $this->taxInvoiceService->update($id, $request->validated());
-
         return ApiResponse::handle(
-            data: $taxInvoice,
-            message: __('message.updated')
+            fn () => $this->taxInvoiceService->update($id, $request->validated()),
+            __('message.updated')
         );
     }
 
@@ -77,11 +68,9 @@ public function update(UpdateTaxInvoiceRequest $request, int $id)
      */
     public function destroy(int $id)
     {
-        $this->taxInvoiceService->delete($id);
-
         return ApiResponse::handle(
-            data: null,
-            message: __('message.deleted')
+            fn () => $this->taxInvoiceService->delete($id),
+            __('message.deleted')
         );
     }
 
@@ -90,11 +79,9 @@ public function destroy(int $id)
      */
     public function issue(int $id)
     {
-        $taxInvoice = $this->taxInvoiceService->issue($id);
-
         return ApiResponse::handle(
-            data: $taxInvoice,
-            message: __('message.tax_invoice.issued')
+            fn () => $this->taxInvoiceService->issue($id),
+            __('message.tax_invoice.issued')
         );
     }
 
@@ -103,11 +90,9 @@ public function issue(int $id)
      */
     public function bulkIssue(BulkIssueRequest $request)
     {
-        $result = $this->taxInvoiceService->bulkIssue($request->getIds());
-
         return ApiResponse::handle(
-            data: $result,
-            message: __('message.tax_invoice.bulk_issued')
+            fn () => $this->taxInvoiceService->bulkIssue($request->getIds()),
+            __('message.tax_invoice.bulk_issued')
         );
     }
 
@@ -116,11 +101,9 @@ public function bulkIssue(BulkIssueRequest $request)
      */
     public function cancel(CancelTaxInvoiceRequest $request, int $id)
     {
-        $taxInvoice = $this->taxInvoiceService->cancel($id, $request->validated()['reason']);
-
         return ApiResponse::handle(
-            data: $taxInvoice,
-            message: __('message.tax_invoice.cancelled')
+            fn () => $this->taxInvoiceService->cancel($id, $request->validated()['reason']),
+            __('message.tax_invoice.cancelled')
         );
     }
 
@@ -129,11 +112,9 @@ public function cancel(CancelTaxInvoiceRequest $request, int $id)
      */
     public function checkStatus(int $id)
     {
-        $taxInvoice = $this->taxInvoiceService->checkStatus($id);
-
         return ApiResponse::handle(
-            data: $taxInvoice,
-            message: __('message.fetched')
+            fn () => $this->taxInvoiceService->checkStatus($id),
+            __('message.fetched')
         );
     }
 
@@ -142,11 +123,9 @@ public function checkStatus(int $id)
      */
     public function summary(TaxInvoiceSummaryRequest $request)
     {
-        $summary = $this->taxInvoiceService->summary($request->validated());
-
         return ApiResponse::handle(
-            data: $summary,
-            message: __('message.fetched')
+            fn () => $this->taxInvoiceService->summary($request->validated()),
+            __('message.fetched')
         );
     }
 
@@ -155,11 +134,9 @@ public function summary(TaxInvoiceSummaryRequest $request)
      */
     public function supplierSettings()
     {
-        $settings = $this->taxInvoiceService->getSupplierSettings();
-
         return ApiResponse::handle(
-            data: $settings,
-            message: __('message.fetched')
+            fn () => $this->taxInvoiceService->getSupplierSettings(),
+            __('message.fetched')
         );
     }
 
@@ -168,11 +145,9 @@ public function supplierSettings()
      */
     public function saveSupplierSettings(SaveSupplierSettingsRequest $request)
     {
-        $settings = $this->taxInvoiceService->saveSupplierSettings($request->validated());
-
         return ApiResponse::handle(
-            data: $settings,
-            message: __('message.updated')
+            fn () => $this->taxInvoiceService->saveSupplierSettings($request->validated()),
+            __('message.updated')
         );
     }
 
@@ -181,12 +156,9 @@ public function saveSupplierSettings(SaveSupplierSettingsRequest $request)
      */
     public function storeAndIssue(CreateTaxInvoiceRequest $request)
     {
-        $taxInvoice = $this->taxInvoiceService->createAndIssue($request->validated());
-
         return ApiResponse::handle(
-            data: $taxInvoice,
-            message: __('message.tax_invoice.issued'),
-            status: 201
+            fn () => $this->taxInvoiceService->createAndIssue($request->validated()),
+            __('message.tax_invoice.issued')
         );
     }
 }