Files
sam-api/app/Services/WorkOrderService.php
kent 349917f019 refactor(work-orders): 코드 리뷰 기반 전면 개선
## Critical 수정
- Multi-tenancy: WorkOrderItem, BendingDetail, Issue에 BelongsToTenant 적용
- 감사 로그: 상태변경, 품목수정, 이슈 등록/해결 시 로깅 추가
- 상태 전이 규칙: STATUS_TRANSITIONS + canTransitionTo() 구현

## High 수정
- 다중 담당자: work_order_assignees 피벗 테이블 및 관계 추가
- 부분 수정: 품목 ID 기반 upsert/delete 로직 구현

## 변경 파일
- Models: WorkOrder, WorkOrderAssignee(신규), 하위 모델들
- Services: WorkOrderService (assign, update 메서드 개선)
- Migrations: tenant_id 추가, assignees 테이블 생성

Co-Authored-By: Claude <noreply@anthropic.com>
2026-01-09 08:32:44 +09:00

592 lines
19 KiB
PHP

<?php
namespace App\Services;
use App\Models\Production\WorkOrder;
use App\Models\Production\WorkOrderAssignee;
use App\Models\Production\WorkOrderBendingDetail;
use App\Services\Audit\AuditLogger;
use Illuminate\Support\Facades\DB;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
class WorkOrderService extends Service
{
private const AUDIT_TARGET = 'work_order';
public function __construct(
private readonly AuditLogger $auditLogger
) {}
/**
* 목록 조회 (검색/필터링/페이징)
*/
public function index(array $params)
{
$tenantId = $this->tenantId();
$page = (int) ($params['page'] ?? 1);
$size = (int) ($params['size'] ?? 20);
$q = trim((string) ($params['q'] ?? ''));
$status = $params['status'] ?? null;
$processType = $params['process_type'] ?? null;
$assigneeId = $params['assignee_id'] ?? null;
$teamId = $params['team_id'] ?? null;
$scheduledFrom = $params['scheduled_from'] ?? null;
$scheduledTo = $params['scheduled_to'] ?? null;
$query = WorkOrder::query()
->where('tenant_id', $tenantId)
->with(['assignee:id,name', 'assignees.user:id,name', 'team:id,name', 'salesOrder:id,order_no']);
// 검색어
if ($q !== '') {
$query->where(function ($qq) use ($q) {
$qq->where('work_order_no', 'like', "%{$q}%")
->orWhere('project_name', 'like', "%{$q}%");
});
}
// 상태 필터
if ($status !== null) {
$query->where('status', $status);
}
// 공정유형 필터
if ($processType !== null) {
$query->where('process_type', $processType);
}
// 담당자 필터
if ($assigneeId !== null) {
$query->where('assignee_id', $assigneeId);
}
// 팀 필터
if ($teamId !== null) {
$query->where('team_id', $teamId);
}
// 예정일 범위
if ($scheduledFrom !== null) {
$query->where('scheduled_date', '>=', $scheduledFrom);
}
if ($scheduledTo !== null) {
$query->where('scheduled_date', '<=', $scheduledTo);
}
$query->orderByDesc('created_at');
return $query->paginate($size, ['*'], 'page', $page);
}
/**
* 통계 조회
*/
public function stats(): array
{
$tenantId = $this->tenantId();
$counts = WorkOrder::where('tenant_id', $tenantId)
->select('status', DB::raw('count(*) as count'))
->groupBy('status')
->pluck('count', 'status')
->toArray();
return [
'total' => array_sum($counts),
'unassigned' => $counts[WorkOrder::STATUS_UNASSIGNED] ?? 0,
'pending' => $counts[WorkOrder::STATUS_PENDING] ?? 0,
'waiting' => $counts[WorkOrder::STATUS_WAITING] ?? 0,
'in_progress' => $counts[WorkOrder::STATUS_IN_PROGRESS] ?? 0,
'completed' => $counts[WorkOrder::STATUS_COMPLETED] ?? 0,
'shipped' => $counts[WorkOrder::STATUS_SHIPPED] ?? 0,
];
}
/**
* 단건 조회
*/
public function show(int $id)
{
$tenantId = $this->tenantId();
$workOrder = WorkOrder::where('tenant_id', $tenantId)
->with([
'assignee:id,name',
'assignees.user:id,name',
'team:id,name',
'salesOrder:id,order_no,project_name',
'items',
'bendingDetail',
'issues' => fn ($q) => $q->orderByDesc('created_at'),
])
->find($id);
if (! $workOrder) {
throw new NotFoundHttpException(__('error.not_found'));
}
return $workOrder;
}
/**
* 생성
*/
public function store(array $data)
{
$tenantId = $this->tenantId();
$userId = $this->apiUserId();
return DB::transaction(function () use ($data, $tenantId, $userId) {
// 작업지시번호 자동 생성
$data['work_order_no'] = $this->generateWorkOrderNo($tenantId);
$data['tenant_id'] = $tenantId;
$data['created_by'] = $userId;
$data['updated_by'] = $userId;
// 담당자가 있으면 상태를 pending으로
if (! empty($data['assignee_id'])) {
$data['status'] = $data['status'] ?? WorkOrder::STATUS_PENDING;
}
$items = $data['items'] ?? [];
$bendingDetail = $data['bending_detail'] ?? null;
unset($data['items'], $data['bending_detail']);
$workOrder = WorkOrder::create($data);
// 품목 저장
foreach ($items as $index => $item) {
$item['tenant_id'] = $tenantId;
$item['sort_order'] = $index;
$workOrder->items()->create($item);
}
// 벤딩 상세 저장 (벤딩 공정인 경우)
if ($data['process_type'] === WorkOrder::PROCESS_BENDING && $bendingDetail) {
$bendingDetail['tenant_id'] = $tenantId;
$workOrder->bendingDetail()->create($bendingDetail);
}
// 감사 로그
$this->auditLogger->log(
$tenantId,
self::AUDIT_TARGET,
$workOrder->id,
'created',
null,
$workOrder->toArray()
);
return $workOrder->load(['assignee:id,name', 'assignees.user:id,name', 'team:id,name', 'items', 'bendingDetail']);
});
}
/**
* 수정
*/
public function update(int $id, array $data)
{
$tenantId = $this->tenantId();
$userId = $this->apiUserId();
$workOrder = WorkOrder::where('tenant_id', $tenantId)->find($id);
if (! $workOrder) {
throw new NotFoundHttpException(__('error.not_found'));
}
$beforeData = $workOrder->toArray();
return DB::transaction(function () use ($workOrder, $data, $userId, $beforeData) {
$data['updated_by'] = $userId;
$items = $data['items'] ?? null;
$bendingDetail = $data['bending_detail'] ?? null;
unset($data['items'], $data['bending_detail'], $data['work_order_no']); // 번호 변경 불가
// 품목 수정 시 기존 품목 기록
$oldItems = null;
if ($items !== null) {
$oldItems = $workOrder->items()->get()->toArray();
}
$workOrder->update($data);
// 품목 부분 수정 (ID 기반 upsert/delete)
if ($items !== null) {
$existingIds = $workOrder->items()->pluck('id')->toArray();
$incomingIds = [];
foreach ($items as $index => $item) {
$itemData = [
'tenant_id' => $workOrder->tenant_id,
'item_name' => $item['item_name'] ?? null,
'specification' => $item['specification'] ?? null,
'quantity' => $item['quantity'] ?? 1,
'unit' => $item['unit'] ?? null,
'sort_order' => $index,
];
if (isset($item['id']) && $item['id']) {
// ID가 있으면 업데이트
$existingItem = $workOrder->items()->find($item['id']);
if ($existingItem) {
$existingItem->update($itemData);
$incomingIds[] = (int) $item['id'];
}
} else {
// ID가 없으면 신규 생성
$newItem = $workOrder->items()->create($itemData);
$incomingIds[] = $newItem->id;
}
}
// 요청에 없는 기존 품목 삭제
$toDelete = array_diff($existingIds, $incomingIds);
if (! empty($toDelete)) {
$workOrder->items()->whereIn('id', $toDelete)->delete();
}
// 품목 수정 감사 로그
$this->auditLogger->log(
$workOrder->tenant_id,
self::AUDIT_TARGET,
$workOrder->id,
'items_updated',
['items' => $oldItems],
['items' => $workOrder->items()->get()->toArray()]
);
}
// 벤딩 상세 업데이트
if ($bendingDetail !== null && $workOrder->process_type === WorkOrder::PROCESS_BENDING) {
$bendingDetail['tenant_id'] = $workOrder->tenant_id;
$workOrder->bendingDetail()->updateOrCreate(
['work_order_id' => $workOrder->id],
$bendingDetail
);
}
// 수정 감사 로그
$this->auditLogger->log(
$workOrder->tenant_id,
self::AUDIT_TARGET,
$workOrder->id,
'updated',
$beforeData,
$workOrder->fresh()->toArray()
);
return $workOrder->load(['assignee:id,name', 'assignees.user:id,name', 'team:id,name', 'items', 'bendingDetail']);
});
}
/**
* 삭제
*/
public function destroy(int $id)
{
$tenantId = $this->tenantId();
$workOrder = WorkOrder::where('tenant_id', $tenantId)->find($id);
if (! $workOrder) {
throw new NotFoundHttpException(__('error.not_found'));
}
// 진행 중이거나 완료된 작업은 삭제 불가
if (in_array($workOrder->status, [
WorkOrder::STATUS_IN_PROGRESS,
WorkOrder::STATUS_COMPLETED,
WorkOrder::STATUS_SHIPPED,
])) {
throw new BadRequestHttpException(__('error.work_order.cannot_delete_in_progress'));
}
$beforeData = $workOrder->toArray();
$workOrder->delete();
// 삭제 감사 로그
$this->auditLogger->log(
$tenantId,
self::AUDIT_TARGET,
$workOrder->id,
'deleted',
$beforeData,
null
);
return 'success';
}
/**
* 상태 변경
*/
public function updateStatus(int $id, string $status)
{
$tenantId = $this->tenantId();
$userId = $this->apiUserId();
$workOrder = WorkOrder::where('tenant_id', $tenantId)->find($id);
if (! $workOrder) {
throw new NotFoundHttpException(__('error.not_found'));
}
// 상태 유효성 검증
if (! in_array($status, WorkOrder::STATUSES)) {
throw new BadRequestHttpException(__('error.invalid_status'));
}
// 상태 전이 규칙 검증
if (! $workOrder->canTransitionTo($status)) {
$allowed = implode(', ', $workOrder->getAllowedTransitions());
throw new BadRequestHttpException(
__('error.work_order.invalid_transition', [
'from' => $workOrder->status,
'to' => $status,
'allowed' => $allowed,
])
);
}
$oldStatus = $workOrder->status;
$workOrder->status = $status;
$workOrder->updated_by = $userId;
// 상태에 따른 타임스탬프 업데이트
switch ($status) {
case WorkOrder::STATUS_IN_PROGRESS:
$workOrder->started_at = $workOrder->started_at ?? now();
break;
case WorkOrder::STATUS_COMPLETED:
$workOrder->completed_at = now();
break;
case WorkOrder::STATUS_SHIPPED:
$workOrder->shipped_at = now();
break;
}
$workOrder->save();
// 상태 변경 감사 로그
$this->auditLogger->log(
$tenantId,
self::AUDIT_TARGET,
$workOrder->id,
'status_changed',
['status' => $oldStatus],
['status' => $status]
);
return $workOrder->load(['assignee:id,name', 'assignees.user:id,name', 'team:id,name']);
}
/**
* 담당자 배정 (다중 담당자 지원)
*
* @param int $id 작업지시 ID
* @param array $data 배정 데이터 (assignee_ids: int[], team_id?: int)
*/
public function assign(int $id, array $data)
{
$tenantId = $this->tenantId();
$userId = $this->apiUserId();
$workOrder = WorkOrder::where('tenant_id', $tenantId)->find($id);
if (! $workOrder) {
throw new NotFoundHttpException(__('error.not_found'));
}
return DB::transaction(function () use ($workOrder, $data, $tenantId, $userId) {
// 이전 상태 기록
$beforeAssignees = $workOrder->assignees()->pluck('user_id')->toArray();
$beforePrimaryAssignee = $workOrder->assignee_id;
$beforeTeam = $workOrder->team_id;
// 담당자 ID 배열 처리 (단일 값도 배열로 변환)
$assigneeIds = $data['assignee_ids'] ?? [];
if (isset($data['assignee_id']) && ! empty($data['assignee_id'])) {
// 하위 호환: 단일 assignee_id도 지원
$assigneeIds = is_array($data['assignee_id']) ? $data['assignee_id'] : [$data['assignee_id']];
}
$assigneeIds = array_unique(array_filter($assigneeIds));
// 기존 담당자 삭제 후 새로 추가
$workOrder->assignees()->delete();
foreach ($assigneeIds as $index => $assigneeId) {
WorkOrderAssignee::create([
'tenant_id' => $tenantId,
'work_order_id' => $workOrder->id,
'user_id' => $assigneeId,
'is_primary' => $index === 0, // 첫 번째가 주 담당자
]);
}
// 주 담당자는 work_orders 테이블에도 설정 (하위 호환)
$primaryAssigneeId = $assigneeIds[0] ?? null;
$workOrder->assignee_id = $primaryAssigneeId;
$workOrder->team_id = $data['team_id'] ?? $workOrder->team_id;
$workOrder->updated_by = $userId;
// 미배정이었으면 대기로 변경
if ($workOrder->status === WorkOrder::STATUS_UNASSIGNED && $primaryAssigneeId) {
$workOrder->status = WorkOrder::STATUS_PENDING;
}
$workOrder->save();
// 배정 감사 로그
$this->auditLogger->log(
$tenantId,
self::AUDIT_TARGET,
$workOrder->id,
'assigned',
[
'assignee_id' => $beforePrimaryAssignee,
'assignee_ids' => $beforeAssignees,
'team_id' => $beforeTeam,
],
[
'assignee_id' => $workOrder->assignee_id,
'assignee_ids' => $assigneeIds,
'team_id' => $workOrder->team_id,
]
);
return $workOrder->load(['assignee:id,name', 'assignees.user:id,name', 'team:id,name']);
});
}
/**
* 벤딩 항목 토글
*/
public function toggleBendingField(int $id, string $field)
{
$tenantId = $this->tenantId();
$workOrder = WorkOrder::where('tenant_id', $tenantId)->find($id);
if (! $workOrder) {
throw new NotFoundHttpException(__('error.not_found'));
}
if ($workOrder->process_type !== WorkOrder::PROCESS_BENDING) {
throw new BadRequestHttpException(__('error.work_order.not_bending_process'));
}
$detail = $workOrder->bendingDetail;
if (! $detail) {
$detail = $workOrder->bendingDetail()->create([
'tenant_id' => $workOrder->tenant_id,
]);
}
if (! in_array($field, WorkOrderBendingDetail::PROCESS_FIELDS)) {
throw new BadRequestHttpException(__('error.invalid_field'));
}
$beforeValue = $detail->{$field};
$detail->toggleField($field);
// 벤딩 토글 감사 로그
$this->auditLogger->log(
$workOrder->tenant_id,
self::AUDIT_TARGET,
$workOrder->id,
'bending_toggled',
[$field => $beforeValue],
[$field => $detail->{$field}]
);
return $detail;
}
/**
* 이슈 추가
*/
public function addIssue(int $workOrderId, array $data)
{
$tenantId = $this->tenantId();
$userId = $this->apiUserId();
$workOrder = WorkOrder::where('tenant_id', $tenantId)->find($workOrderId);
if (! $workOrder) {
throw new NotFoundHttpException(__('error.not_found'));
}
$data['tenant_id'] = $tenantId;
$data['reported_by'] = $userId;
$issue = $workOrder->issues()->create($data);
// 이슈 추가 감사 로그
$this->auditLogger->log(
$tenantId,
self::AUDIT_TARGET,
$workOrderId,
'issue_added',
null,
['issue_id' => $issue->id, 'title' => $issue->title, 'priority' => $issue->priority]
);
return $issue;
}
/**
* 이슈 해결
*/
public function resolveIssue(int $workOrderId, int $issueId)
{
$tenantId = $this->tenantId();
$userId = $this->apiUserId();
$workOrder = WorkOrder::where('tenant_id', $tenantId)->find($workOrderId);
if (! $workOrder) {
throw new NotFoundHttpException(__('error.not_found'));
}
$issue = $workOrder->issues()->find($issueId);
if (! $issue) {
throw new NotFoundHttpException(__('error.not_found'));
}
$issue->resolve($userId);
// 이슈 해결 감사 로그
$this->auditLogger->log(
$tenantId,
self::AUDIT_TARGET,
$workOrderId,
'issue_resolved',
['issue_id' => $issueId, 'status' => 'open'],
['issue_id' => $issueId, 'status' => 'resolved', 'resolved_by' => $userId]
);
return $issue;
}
/**
* 작업지시번호 자동 생성
*/
private function generateWorkOrderNo(int $tenantId): string
{
$prefix = 'WO';
$date = now()->format('Ymd');
// 오늘 날짜 기준 마지막 번호 조회
$lastNo = WorkOrder::withoutGlobalScopes()
->where('tenant_id', $tenantId)
->where('work_order_no', 'like', "{$prefix}{$date}%")
->orderByDesc('work_order_no')
->value('work_order_no');
if ($lastNo) {
$seq = (int) substr($lastNo, -4) + 1;
} else {
$seq = 1;
}
return sprintf('%s%s%04d', $prefix, $date, $seq);
}
}